For posts that receive a lot comments, e.g. 50~100+
When I turn on notifications for a post, I receive the notifications for new comments but the “Go to” link just takes me to the top of the post, not to the specific comment. (Same problem in both Zen/Firefox browser on computer and Firefox/PWA on Android.)
E.g. https://piefed.social/notification/1151084/goto
Is this just me?
That notification url is only going to work for you because it’s your notification, other users are going to be blocked.
As for why this is happening for threads with a large number of comments, it is probably because once a post gets more than a certain number of comments, piefed loads them “lazily”. This means it loads the rest of the page first and then loads the comments and fills them in. So, the page isn’t automatically scrolled to the correct comment when the page loads because the comment isn’t there yet.
I haven’t really looked at this area of the code, but I suspect the solution will have to be some Javascript that triggers the scroll after the comment has loaded. @[email protected] probably knows better though since he wrote the lazy loading.
Thanks for the info!
I have noticed this problem as well - e.g. a notification tried to send you somewhere and if there are a lot of comments in the OP, it breaks the process and just takes you to the top.
Btw the URl you included https://piefed.social/notification/1151084/goto is broken for a different reason, saying instead:
{“code”:403,“status”:“Forbidden”}
Which is a different behavior that what you described.
@wjs018 informs that the Go To links only work for the original user, and that the ‘going to right comment’ issue will need some probably Javascript fix.
Ah.
I fixed this for one type of reply but missed out a different one. It’s fixed for all future notifications, now.
Awesome, thanks!
